Support additional name placeholders in English#13
Open
jimsihk wants to merge 1 commit into
Open
Conversation
jimsihk
force-pushed
the
feat/en-placeholder-name
branch
from
ef0a8f9 to
dcbaeba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current name placeholders "NOMBRE" and "APELLIDO" are in Spanish which might be a little bit difficult for non-Spanish site admins.
I would like to propose supporting additional name placeholders "FIRSTNAME" and "LASTNAME" that are in English. The concept is to be transparent to sites using the existing plugin versions, so the change is to add extra attempts to replace the new placeholders instead of replacing the existing placeholders.